◐ Shell
clean mode source ↗

build: fix building with --build-v8-with-gn by hashseed · Pull Request #21330 · nodejs/node

nodejs-github-bot

@hashseed

@nodejs-github-bot added the build

Issues and PRs related to build files or the CI.

label

Jun 14, 2018

bnoordhuis

addaleax

richardlau

@refack refack added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jun 14, 2018

TimothyGu

BridgeAR

hashseed added a commit that referenced this pull request

Jun 20, 2018 
PR-URL: #21330
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos pushed a commit that referenced this pull request

Jun 20, 2018 
PR-URL: #21330
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>