◐ Shell
clean mode source ↗

win, build: fix building on 32-bit machines by bzoz · Pull Request #21437 · nodejs/node

nodejs-github-bot

@bzoz

@nodejs-github-bot added build

Issues and PRs related to build files or the CI.

windows

Issues and PRs related to the Windows platform.

labels

Jun 21, 2018

richardlau

@BridgeAR BridgeAR added fast-track

PRs that do not need to wait for 72 hours to land.

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

labels

Jun 21, 2018

@ghost ghost mentioned this pull request

Jun 22, 2018

addaleax

apapirovski pushed a commit that referenced this pull request

Jun 25, 2018 
Fixes: #21402

PR-URL: #21437
Fixes: #21402
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos pushed a commit that referenced this pull request

Jun 25, 2018 
Fixes: #21402

PR-URL: #21437
Fixes: #21402
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

refack added a commit to refack/node that referenced this pull request

Aug 16, 2018 
Since we are CI testing on x64 hosts, we can only commit to x64 hosts.

PR-URL: nodejs#21443
Refs: nodejs#21402
Refs: nodejs#21437
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: João Reis <reis@janeasystems.com>

targos pushed a commit that referenced this pull request

Aug 19, 2018 
Since we are CI testing on x64 hosts, we can only commit to x64 hosts.

PR-URL: #21443
Refs: #21402
Refs: #21437
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: João Reis <reis@janeasystems.com>

targos pushed a commit that referenced this pull request

Sep 3, 2018 
Since we are CI testing on x64 hosts, we can only commit to x64 hosts.

PR-URL: #21443
Refs: #21402
Refs: #21437
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: João Reis <reis@janeasystems.com>