◐ Shell
clean mode source ↗

src: fix race on modpending by migrating it to a thread local by rpetrich · Pull Request #21611 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

Jun 30, 2018

addaleax

Fixes a rare race condition on modpending when two native modules are
loaded simultaneously on different threads by migrating modpending to
be a member of Environment.

@rpetrich rpetrich changed the title src: fix race on modpending by migrating it to Environment src: fix race on modpending by migrating it to a thread local

Jun 30, 2018

gabrielschulhof

gabrielschulhof

gabrielschulhof

apapirovski

gabrielschulhof pushed a commit that referenced this pull request

Aug 17, 2018 
Fixes a rare race condition on modpending when two native modules are
loaded simultaneously on different threads by storing it thread-
locally.

PR-URL: #21611
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

targos pushed a commit that referenced this pull request

Aug 19, 2018 
Fixes a rare race condition on modpending when two native modules are
loaded simultaneously on different threads by storing it thread-
locally.

PR-URL: #21611
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

targos pushed a commit that referenced this pull request

Sep 3, 2018 
Fixes a rare race condition on modpending when two native modules are
loaded simultaneously on different threads by storing it thread-
locally.

PR-URL: #21611
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

This was referenced

Sep 6, 2018