◐ Shell
clean mode source ↗

doc: clarify that new URL().port could be an empty string. by mcollina · Pull Request #22232 · nodejs/node

mcollina

@nodejs-github-bot nodejs-github-bot added doc

Issues and PRs related to the documentations.

url

Issues and PRs related to the legacy built-in url module.

labels

Aug 10, 2018

BridgeAR

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Aug 10, 2018

Trott

Trott

Trott

BridgeAR

Trott

@mcollina

BridgeAR

@maclover7 maclover7 removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Aug 15, 2018

mcollina added a commit that referenced this pull request

Aug 17, 2018 
PR-URL: #22232
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>

targos pushed a commit that referenced this pull request

Aug 19, 2018 
PR-URL: #22232
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>

targos pushed a commit that referenced this pull request

Sep 3, 2018 
PR-URL: #22232
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>

This was referenced

Sep 6, 2018