◐ Shell
clean mode source ↗

doc/api: clarify the documentation of pipes and zlib objects in them by andreasg123 · Pull Request #22354 · nodejs/node

nodejs-github-bot

Document how pipes can be chained in readable.pipe().
Document that zlib.Zlib inherits from stream.Transform.

Fixes: #22341

@nodejs-github-bot added the doc

Issues and PRs related to the documentations.

label

Aug 16, 2018

vsemozhetbyt

@vsemozhetbyt vsemozhetbyt added stream

Issues and PRs related to the stream subsystem.

zlib

Issues and PRs related to the zlib subsystem.

labels

Aug 16, 2018

@andreasg123

vsemozhetbyt

mcollina

@andreasg123

BridgeAR

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Aug 17, 2018

vsemozhetbyt pushed a commit that referenced this pull request

Aug 18, 2018 
Document how pipes can be chained in readable.pipe().
Document that zlib.Zlib inherits from stream.Transform.

PR-URL: #22354
Fixes: #22341
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

targos pushed a commit that referenced this pull request

Aug 19, 2018 
Document how pipes can be chained in readable.pipe().
Document that zlib.Zlib inherits from stream.Transform.

PR-URL: #22354
Fixes: #22341
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

targos pushed a commit that referenced this pull request

Sep 3, 2018 
Document how pipes can be chained in readable.pipe().
Document that zlib.Zlib inherits from stream.Transform.

PR-URL: #22354
Fixes: #22341
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

This was referenced

Sep 6, 2018