◐ Shell
clean mode source ↗

src,deps: wrap library name with TEXT() by zcbenz · Pull Request #226 · nodejs/node

piscisaureus

On Windows when compiling with unicode support, "LoadLibrary" will
become "LoadLibraryW" and feeding it with an ANSCII string will cause
crash in runtime.

pushed a commit that referenced this pull request

Jan 7, 2015 
On Windows, when compiling with `UNICODE` defined, `LoadLibrary` becomes
`LoadLibraryW`. When an ASCII string is passed to that function it
crashes.

PR-URL: #226
Reviewed-By: Bert Belder <bertbelder@gmail.com>

bnoordhuis pushed a commit to bnoordhuis/io.js that referenced this pull request

May 11, 2015 
On Windows, when compiling with `UNICODE` defined, `LoadLibrary` becomes
`LoadLibraryW`. When an ASCII string is passed to that function it
crashes.

PR-URL: nodejs#226
Reviewed-By: Bert Belder <bertbelder@gmail.com>

bnoordhuis pushed a commit to bnoordhuis/io.js that referenced this pull request

May 11, 2015 
On Windows, when compiling with `UNICODE` defined, `LoadLibrary` becomes
`LoadLibraryW`. When an ASCII string is passed to that function it
crashes.

PR-URL: nodejs#226
Reviewed-By: Bert Belder <bertbelder@gmail.com>

bnoordhuis pushed a commit to bnoordhuis/io.js that referenced this pull request

May 12, 2015 
On Windows, when compiling with `UNICODE` defined, `LoadLibrary` becomes
`LoadLibraryW`. When an ASCII string is passed to that function it
crashes.

PR-URL: nodejs#226
Reviewed-By: Bert Belder <bertbelder@gmail.com>

Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request

May 19, 2015 
On Windows, when compiling with `UNICODE` defined, `LoadLibrary` becomes
`LoadLibraryW`. When an ASCII string is passed to that function it
crashes.

PR-URL: nodejs#226
Reviewed-By: Bert Belder <bertbelder@gmail.com>

indutny pushed a commit to indutny/io.js that referenced this pull request

Feb 4, 2016 
On Windows, when compiling with `UNICODE` defined, `LoadLibrary` becomes
`LoadLibraryW`. When an ASCII string is passed to that function it
crashes.

PR-URL: nodejs#226
Reviewed-By: Bert Belder <bertbelder@gmail.com>

indutny pushed a commit that referenced this pull request

Feb 8, 2016 
On Windows, when compiling with `UNICODE` defined, `LoadLibrary` becomes
`LoadLibraryW`. When an ASCII string is passed to that function it
crashes.

PR-URL: #226
Reviewed-By: Bert Belder <bertbelder@gmail.com>

rvagg pushed a commit that referenced this pull request

Feb 9, 2016 
On Windows, when compiling with `UNICODE` defined, `LoadLibrary` becomes
`LoadLibraryW`. When an ASCII string is passed to that function it
crashes.

PR-URL: #226
Reviewed-By: Bert Belder <bertbelder@gmail.com>

rvagg pushed a commit that referenced this pull request

Feb 9, 2016 
On Windows, when compiling with `UNICODE` defined, `LoadLibrary` becomes
`LoadLibraryW`. When an ASCII string is passed to that function it
crashes.

PR-URL: #226
Reviewed-By: Bert Belder <bertbelder@gmail.com>

scovetta pushed a commit to scovetta/node that referenced this pull request

Apr 2, 2016 
On Windows, when compiling with `UNICODE` defined, `LoadLibrary` becomes
`LoadLibraryW`. When an ASCII string is passed to that function it
crashes.

PR-URL: nodejs#226
Reviewed-By: Bert Belder <bertbelder@gmail.com>

isaacs added a commit to npm/node that referenced this pull request

Aug 6, 2019

This was referenced

Feb 11, 2024

This was referenced

Feb 11, 2024

@ZRDK ZRDK mentioned this pull request

Feb 11, 2024