◐ Shell
clean mode source ↗

src: generate debug symbols bundle on OS X by zcbenz · Pull Request #227 · nodejs/node

Conversation

@zcbenz

This will generate *.dSYM symbols on OS X, when we dispatch Node
binaries without debug symbols to users, it can be used to restore
meaningful stack trace from the crash report.

It doesn't affect generated binary.

@bnoordhuis

LGTM but out of curiosity, how big are the debug symbols? It would be somewhat unfortunate if the build starts writing gigabytes of mostly unused symbol data (think out of disk space errors.)

This will generate *.dSYM symbols on OS X, when we dispatch Node
binaries without debug symbols to users, it can be used to restore
meaningful stack trace from the crash report.

@zcbenz

I just updated the patch to only generate symbols for node target, so we won't waste time generating symbols for openssl-cli and others.

This patch now only generates a node.dSYM which is 187M in size, it also adds 10s building time on my machine.

@bnoordhuis

That's a little on the steep side IMO. When you say "can be used to restore meaningful stack trace from the crash report", who/what does that? The binary already has debug symbols.

@zcbenz

This is mostly used by developers building products based on io.js, who will distribute binaries that have no debug symbols, I have to admit it doesn't have much value to io.js itself. I'm OK to close this if you think it is not suitable to put it in upstream.

@bnoordhuis

@zcbenz Thanks for your reply, I'll go ahead and close this.

isaacs added a commit to npm/node that referenced this pull request

Aug 6, 2019

Trott pushed a commit that referenced this pull request

Aug 20, 2019

BridgeAR pushed a commit that referenced this pull request

Sep 3, 2019

BethGriggs pushed a commit that referenced this pull request

Oct 19, 2019

@ambai ambai mentioned this pull request

Feb 2, 2024

2 participants

@zcbenz @bnoordhuis