◐ Shell
clean mode source ↗

Improved memory management code in ParseSoaReply() by uttampawar · Pull Request #23628 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

cares

Issues and PRs related to the c-ares dependency or the cares_wrap binding.

labels

Oct 12, 2018

addaleax

@addaleax addaleax added the code-and-learn

Issues related to the Code-and-Learn events and PRs submitted during the events.

label

Oct 12, 2018

joyeecheung

refack

refack

refack

refack

refack

refack

addaleax

targos pushed a commit that referenced this pull request

Oct 24, 2018 
Introduced use of smart pointers instead of MallocedBuffer to manage
memory allocated in the cares library.

PR-URL: #23628
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

This was referenced

Nov 2, 2018

codebytere pushed a commit that referenced this pull request

Dec 13, 2018 
Introduced use of smart pointers instead of MallocedBuffer to manage
memory allocated in the cares library.

PR-URL: #23628
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 26, 2018 
Introduced use of smart pointers instead of MallocedBuffer to manage
memory allocated in the cares library.

PR-URL: #23628
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

This was referenced

Jan 29, 2019