◐ Shell
clean mode source ↗

doc, test: document and test vm timeout escapes by jasnell · Pull Request #23743 · nodejs/node

@jasnell added doc

Issues and PRs related to the documentations.

vm

Issues and PRs related to the vm subsystem.

known limitation

Issues that are identified as known limitations.

labels

Oct 18, 2018

TimothyGu

@vsemozhetbyt vsemozhetbyt added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Oct 19, 2018

@jasnell jasnell removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Oct 23, 2018
Using `process.nextTick()`, `Promise`, or `queueMicrotask()`, it
is possible to escape the `timeout` set when running code with
`vm.runInContext()`, `vm.runInThisContext()`, and
`vm.runInNewContext()`.

This documents the issue and adds three known_issues tests.

Refs: nodejs#3020
These are known issues that can be flaky on certain platforms
because they rely entirely on timing differences.

jasnell added a commit that referenced this pull request

Oct 24, 2018
Using `process.nextTick()`, `Promise`, or `queueMicrotask()`, it
is possible to escape the `timeout` set when running code with
`vm.runInContext()`, `vm.runInThisContext()`, and
`vm.runInNewContext()`.

This documents the issue and adds three known_issues tests.

Refs: #3020
PR-URL: #23743
Refs: #3020
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

jasnell added a commit that referenced this pull request

Oct 24, 2018
These are known issues that can be flaky on certain platforms
because they rely entirely on timing differences.

PR-URL: #23743
Refs: #3020
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

targos pushed a commit that referenced this pull request

Oct 26, 2018
Using `process.nextTick()`, `Promise`, or `queueMicrotask()`, it
is possible to escape the `timeout` set when running code with
`vm.runInContext()`, `vm.runInThisContext()`, and
`vm.runInNewContext()`.

This documents the issue and adds three known_issues tests.

Refs: #3020
PR-URL: #23743
Refs: #3020
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

targos pushed a commit that referenced this pull request

Oct 26, 2018
These are known issues that can be flaky on certain platforms
because they rely entirely on timing differences.

PR-URL: #23743
Refs: #3020
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

This was referenced

Nov 2, 2018

codebytere pushed a commit that referenced this pull request

Dec 13, 2018
Using `process.nextTick()` or `Promise`, it
is possible to escape the `timeout` set when running code with
`vm.runInContext()`, `vm.runInThisContext()`, and
`vm.runInNewContext()`.

This documents the issue and adds two known_issues tests.

Refs: #3020
PR-URL: #23743
Refs: #3020
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

codebytere pushed a commit that referenced this pull request

Dec 13, 2018
These are known issues that can be flaky on certain platforms
because they rely entirely on timing differences.

PR-URL: #23743
Refs: #3020
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 26, 2018
Using `process.nextTick()` or `Promise`, it
is possible to escape the `timeout` set when running code with
`vm.runInContext()`, `vm.runInThisContext()`, and
`vm.runInNewContext()`.

This documents the issue and adds two known_issues tests.

Refs: #3020
PR-URL: #23743
Refs: #3020
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 26, 2018
These are known issues that can be flaky on certain platforms
because they rely entirely on timing differences.

PR-URL: #23743
Refs: #3020
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

This was referenced

Jan 29, 2019

@sam-github sam-github added flaky-test

Issues and PRs related to the tests with unstable failures on the CI.

linux

Issues and PRs related to the Linux platform.

labels

Jun 7, 2019