◐ Shell
clean mode source ↗

timers: fix priority queue removeAt fn by apapirovski · Pull Request #23870 · nodejs/node

apapirovski

addaleax

@apapirovski

@apapirovski apapirovski added the timers

Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

label

Oct 25, 2018

BridgeAR

mcollina

TimothyGu

Trott pushed a commit to Trott/io.js that referenced this pull request

Oct 25, 2018 
PR-URL: nodejs#23870
Fixes: nodejs#23860
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos pushed a commit that referenced this pull request

Oct 26, 2018 
PR-URL: #23870
Fixes: #23860
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request

Oct 28, 2018 
Notable changes:

* deps
  * Updated ICU to 63.1. #23715
* repl
  * Top-level for-await-of is now supported in the REPL.
    #23841
* timers
  * Fixed an issue that could cause timers to enter an infinite loop.
    #23870

PR-URL: #23922

@xPaw xPaw mentioned this pull request

Oct 29, 2018

targos pushed a commit that referenced this pull request

Nov 1, 2018 
PR-URL: #23870
Fixes: #23860
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request

Nov 1, 2018 
Notable changes:

* deps
  * Updated ICU to 63.1. #23715
* repl
  * Top-level for-await-of is now supported in the REPL.
    #23841
* timers
  * Fixed an issue that could cause timers to enter an infinite loop.
    #23870

PR-URL: #23922

targos added a commit that referenced this pull request

Nov 2, 2018 
Notable changes:

* deps
  * Updated ICU to 63.1. #23715
* repl
  * Top-level for-await-of is now supported in the REPL.
    #23841
* timers
  * Fixed an issue that could cause timers to enter an infinite loop.
    #23870

PR-URL: #23922

@Zirro Zirro mentioned this pull request

Nov 2, 2018

This was referenced

Nov 2, 2018