◐ Shell
clean mode source ↗

v8 module: allow TypedArray and DataView by oyyd · Pull Request #23953 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

Oct 29, 2018

@oyyd oyyd mentioned this pull request

Oct 29, 2018

@jasnell jasnell added the semver-minor

PRs that contain new features and should be released in the next minor version.

label

Oct 29, 2018

bnoordhuis

refack

refack

@refack refack added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Oct 30, 2018 
This commit allow passing `TypedArray` and `DataView` to:
- v8.deserialize()
- new v8.Deserializer()
- v8.serializer.writeRawBytes()

PR-URL: nodejs#23953
Refs: nodejs#1826
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Refael Ackermann <refack@gmail.com>

@refack refack removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Oct 31, 2018

targos pushed a commit that referenced this pull request

Nov 2, 2018 
This commit allow passing `TypedArray` and `DataView` to:
- v8.deserialize()
- new v8.Deserializer()
- v8.serializer.writeRawBytes()

PR-URL: #23953
Refs: #1826
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Refael Ackermann <refack@gmail.com>

This was referenced

Nov 15, 2018

BethGriggs pushed a commit that referenced this pull request

Apr 8, 2019 
This commit allow passing `TypedArray` and `DataView` to:
- v8.deserialize()
- new v8.Deserializer()
- v8.serializer.writeRawBytes()

PR-URL: #23953
Refs: #1826
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Refael Ackermann <refack@gmail.com>

This was referenced

May 29, 2019