◐ Shell
clean mode source ↗

test: fix test-fs-watch-system-limit by ofrobots · Pull Request #23986 · nodejs/node

nodejs-github-bot

On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Oct 31, 2018

richardlau

@ofrobots ofrobots added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Nov 1, 2018

Trott pushed a commit to Trott/io.js that referenced this pull request

Nov 2, 2018 
On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.

PR-URL: nodejs#23986
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request

Nov 2, 2018 
On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.

PR-URL: #23986
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

This was referenced

Nov 15, 2018

MylesBorins pushed a commit that referenced this pull request

Nov 27, 2018 
On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.

PR-URL: #23986
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

rvagg pushed a commit that referenced this pull request

Nov 28, 2018 
On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.

PR-URL: #23986
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Nov 29, 2018 
On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.

PR-URL: #23986
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 3, 2018 
On some systems the default inotify limits might be too high for the
test to actually fail. Detect and skip the test in such environments.

PR-URL: #23986
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>