◐ Shell
clean mode source ↗

Revert "child_process: change windowsHide default to true" by Trott · Pull Request #24034 · nodejs/node

@Trott

@nodejs-github-bot added the child_process

Issues and PRs related to the child_process subsystem.

label

Nov 2, 2018

@Trott Trott mentioned this pull request

Nov 2, 2018

4 tasks

@refack refack added the windows

Issues and PRs related to the Windows platform.

label

Nov 2, 2018

@Trott

codebytere

ryzokuken

bzoz

bzoz approved these changes Nov 8, 2018

MarshallOfSound

ofrobots

Trott added a commit to Trott/io.js that referenced this pull request

Nov 13, 2018
This reverts commit 420d8af.

PR-URL: nodejs#24034
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

BridgeAR added a commit that referenced this pull request

Nov 14, 2018

BridgeAR pushed a commit that referenced this pull request

Nov 14, 2018
This reverts commit 420d8af.

PR-URL: #24034
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

BridgeAR added a commit that referenced this pull request

Nov 14, 2018

kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request

Nov 15, 2018
This reverts commit 420d8af.

PR-URL: nodejs#24034
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

BridgeAR pushed a commit that referenced this pull request

Nov 15, 2018
This reverts commit 420d8af.

PR-URL: #24034
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

targos pushed a commit that referenced this pull request

Nov 15, 2018
Notable changes:

* deps:
  * A new experimental HTTP parser (`llhttp`) is now supported.
    #24059
* timers:
  * Fixed an issue that could cause setTimeout to stop working as
    expected. #24322
* Windows
  * A crashing process will now show the names of stack frames if the
    node.pdb file is available.
    #23822
  * Continued effort to improve the installer's new stage that installs
    native build tools.
    #23987,
    #24348
  * child_process:
    * On Windows the `windowsHide` option default was restored to
      `false`. This means `detached` child processes and GUI apps will
      once again start in a new window.
      #24034
* Added new collaborators:
  * [oyyd](https://github.com/oyyd) - Ouyang Yadong.
    #24300
  * [psmarshall](https://github.com/psmarshall) - Peter Marshall.
    #24170
  * [shisama](https://github.com/shisama) - Masashi Hirano.
    #24136

targos pushed a commit that referenced this pull request

Nov 15, 2018
Notable changes:

* deps:
  * A new experimental HTTP parser (`llhttp`) is now supported.
    #24059
* timers:
  * Fixed an issue that could cause setTimeout to stop working as
    expected. #24322
* Windows
  * A crashing process will now show the names of stack frames if the
    node.pdb file is available.
    #23822
  * Continued effort to improve the installer's new stage that installs
    native build tools.
    #23987,
    #24348
  * child_process:
    * On Windows the `windowsHide` option default was restored to
      `false`. This means `detached` child processes and GUI apps will
      once again start in a new window.
      #24034
* Added new collaborators:
  * [oyyd](https://github.com/oyyd) - Ouyang Yadong.
    #24300
  * [psmarshall](https://github.com/psmarshall) - Peter Marshall.
    #24170
  * [shisama](https://github.com/shisama) - Masashi Hirano.
    #24136

PR-URL: #24350

This was referenced

Nov 15, 2018

@Trott Trott deleted the revert-420d8af branch

January 13, 2022 22:50