◐ Shell
clean mode source ↗

build: only try to run node when it's needed by the target by joyeecheung · Pull Request #24115 · nodejs/node

joyeecheung

Right now `node -p process.versions.openssl` always gets run
in the Makefile even when it's not needed by the target
(e.g. `make clean`, `make test-only`). This patch makes it
a run time call instead of part of the global expansion.

richardlau

@joyeecheung joyeecheung changed the title build: only try to find node when it's needed by the target build: only try to run node when it's needed by the target

Nov 6, 2018

danbev

joyeecheung

@joyeecheung

@joyeecheung joyeecheung added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Nov 6, 2018

Trott pushed a commit to Trott/io.js that referenced this pull request

Nov 8, 2018 
Right now `node -p process.versions.openssl` always gets run
in the Makefile even when it's not needed by the target
(e.g. `make clean`, `make test-only`). This patch makes it
a run time call instead of part of the global expansion.

PR-URL: nodejs#24115
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

BridgeAR pushed a commit that referenced this pull request

Nov 14, 2018 
Right now `node -p process.versions.openssl` always gets run
in the Makefile even when it's not needed by the target
(e.g. `make clean`, `make test-only`). This patch makes it
a run time call instead of part of the global expansion.

PR-URL: #24115
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request

Nov 15, 2018 
Right now `node -p process.versions.openssl` always gets run
in the Makefile even when it's not needed by the target
(e.g. `make clean`, `make test-only`). This patch makes it
a run time call instead of part of the global expansion.

PR-URL: nodejs#24115
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

This was referenced

Nov 15, 2018

codebytere pushed a commit that referenced this pull request

Dec 13, 2018 
Right now `node -p process.versions.openssl` always gets run
in the Makefile even when it's not needed by the target
(e.g. `make clean`, `make test-only`). This patch makes it
a run time call instead of part of the global expansion.

PR-URL: #24115
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 26, 2018 
Right now `node -p process.versions.openssl` always gets run
in the Makefile even when it's not needed by the target
(e.g. `make clean`, `make test-only`). This patch makes it
a run time call instead of part of the global expansion.

PR-URL: #24115
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

This was referenced

Jan 29, 2019