◐ Shell
clean mode source ↗

test: fs readfile, swap arguments in strictEqual by dodev · Pull Request #24133 · nodejs/node

nodejs-github-bot

@dodev

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Nov 6, 2018

addaleax

@addaleax addaleax added the code-and-learn

Issues related to the Code-and-Learn events and PRs submitted during the events.

label

Nov 6, 2018

BridgeAR

@trivikr trivikr added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

and removed author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

labels

Nov 7, 2018

gireeshpunathil

Trott pushed a commit to Trott/io.js that referenced this pull request

Nov 8, 2018 
PR-URL: nodejs#24133
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

BridgeAR pushed a commit that referenced this pull request

Nov 14, 2018 
PR-URL: #24133
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request

Nov 15, 2018 
PR-URL: nodejs#24133
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

This was referenced

Nov 15, 2018

codebytere pushed a commit that referenced this pull request

Dec 13, 2018 
PR-URL: #24133
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

MylesBorins pushed a commit that referenced this pull request

Dec 26, 2018 
PR-URL: #24133
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

This was referenced

Jan 29, 2019