◐ Shell
clean mode source ↗

test: fix invalid argument order in test-http-expect-continue.js by mroderick · Pull Request #24138 · nodejs/node

cjihrig

`assert.strictEqual` expects arguments in the following order:

actual, expected[, message]

cjihrig

approved these changes Nov 6, 2018

addaleax

@addaleax addaleax added code-and-learn

Issues related to the Code-and-Learn events and PRs submitted during the events.

test

Issues and PRs related to the tests.

labels

Nov 6, 2018

BridgeAR

gireeshpunathil

Trott pushed a commit to Trott/io.js that referenced this pull request

Nov 8, 2018 
`assert.strictEqual` expects arguments in the following order:

actual, expected[, message]

PR-URL: nodejs#24138
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

BridgeAR pushed a commit that referenced this pull request

Nov 14, 2018 
`assert.strictEqual` expects arguments in the following order:

actual, expected[, message]

PR-URL: #24138
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request

Nov 15, 2018 
`assert.strictEqual` expects arguments in the following order:

actual, expected[, message]

PR-URL: nodejs#24138
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

This was referenced

Nov 15, 2018

codebytere pushed a commit that referenced this pull request

Dec 13, 2018 
`assert.strictEqual` expects arguments in the following order:

actual, expected[, message]

PR-URL: #24138
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

MylesBorins pushed a commit that referenced this pull request

Dec 26, 2018 
`assert.strictEqual` expects arguments in the following order:

actual, expected[, message]

PR-URL: #24138
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

This was referenced

Jan 29, 2019