◐ Shell
clean mode source ↗

src: add DCHECK macros by kiyomizumia · Pull Request #24359 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

lib / src

Issues and PRs related to general changes in the lib or src directory.

labels

Nov 14, 2018

addaleax

test: fixed order of actual and expected arguments

src: ifdef changes

src: refactored and removed some ifdef debug statements

joyeecheung

joyeecheung

@kiyomizumia

joyeecheung

@addaleax addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Nov 24, 2018

@kiyomizumia

joyeecheung

addaleax

@Trott Trott removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Nov 25, 2018 
Co-Authored-By: kiyomizumia <42000558+kiyomizumia@users.noreply.github.com>

@addaleax addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Dec 19, 2018

BridgeAR

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

Dec 24, 2018 
This adds check statements for debugging and refactors the code
accordingly.

PR-URL: nodejs#24359
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins pushed a commit that referenced this pull request

Dec 25, 2018 
This adds check statements for debugging and refactors the code
accordingly.

PR-URL: #24359
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins pushed a commit that referenced this pull request

Dec 26, 2018 
This adds check statements for debugging and refactors the code
accordingly.

PR-URL: #24359
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

refack pushed a commit to refack/node that referenced this pull request

Jan 14, 2019 
This adds check statements for debugging and refactors the code
accordingly.

PR-URL: nodejs#24359
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>