◐ Shell
clean mode source ↗

[v6.x] http: fix regression of binary upgrade response body by mcollina · Pull Request #25036 · nodejs/node

nodejs-github-bot

Skip to content

Navigation Menu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@mcollina

See: #24958

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

http_parser

Issues and PRs related to the HTTP Parser dependency or the http_parser binding.

v6.x labels

Dec 14, 2018

@mcollina

@mcollina

@mcollina mcollina changed the title http: fix regression of binary upgrade response body [v6.x] http: fix regression of binary upgrade response body

Dec 14, 2018

@lpinca

I think both this and #25037 can be cherry-picked from #25039 once merged no?

@lpinca

@Trott Trott mentioned this pull request

Dec 14, 2018

MylesBorins

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MylesBorins pushed a commit that referenced this pull request

Dec 21, 2018 
See: #24958

PR-URL: #25036
Reviewed-By: Myles Borins <myles.borins@gmail.com>

@MylesBorins

MylesBorins pushed a commit that referenced this pull request

Dec 21, 2018 
See: #24958

PR-URL: #25036
Reviewed-By: Myles Borins <myles.borins@gmail.com>

This was referenced

Dec 26, 2018

Labels

c++

Issues and PRs that require attention from people who are familiar with C++.

http_parser

Issues and PRs related to the HTTP Parser dependency or the http_parser binding.