◐ Shell
clean mode source ↗

src: mark some global state as const by addaleax · Pull Request #25052 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

lib / src

Issues and PRs related to general changes in the lib or src directory.

labels

Dec 14, 2018

@addaleax addaleax changed the title src: make some global state as const src: mark some global state as const

Dec 14, 2018 
Mark some global variables as `const` or `constexpr`.

joyeecheung

joyeecheung

@addaleax

@addaleax addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Dec 15, 2018

joyeecheung

Trott pushed a commit to Trott/io.js that referenced this pull request

Dec 17, 2018 
Mark some global variables as `const` or `constexpr`.

PR-URL: nodejs#25052
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Dec 25, 2018 
Mark some global variables as `const` or `constexpr`.

PR-URL: #25052
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

refack pushed a commit to refack/node that referenced this pull request

Jan 14, 2019 
Mark some global variables as `const` or `constexpr`.

PR-URL: nodejs#25052
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>