[v8.x] update the http.request.setTimeout docs to be accurate by jbunton-atlassian · Pull Request #25123 · nodejs/node
Conversation
When upgrading from Node.js 8 to 10 I hit the behaviour change in #8895. This documentation update would have helped me find the problem faster :)
Also see #25121 for an update to the docs on master.
Thanks :)
Checklist
- documentation is changed or added
- commit message follows commit guidelines
Original commit message:
[cpu-profiler] Fix a leak caused by re-logging existing functions.
Don't re-log all existing functions during StartProcessorIfNotStarted().
They will already be in the CodeMap attached to the ProfileGenerator and
re-logging them causes leaks. See the linked bug for more details.
Bug: v8:8253
Change-Id: Ibb1a1ab2431c588e8c3a3a9ff714767cdf61a88e
Reviewed-on: https://chromium-review.googlesource.com/1256763
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{nodejs#56336}
Refs: v8/v8@525b396
PR-URL: nodejs#25041
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Rod Vagg <rod@vagg.org>
This was referenced
MylesBorins pushed a commit that referenced this pull request
addaleax
changed the title
update the http.request.setTimeout docs to be accurate
[v8.x] update the http.request.setTimeout docs to be accurate
MylesBorins pushed a commit that referenced this pull request
rvagg pushed a commit that referenced this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters