◐ Shell
clean mode source ↗

[v8.x] update the http.request.setTimeout docs to be accurate by jbunton-atlassian · Pull Request #25123 · nodejs/node

Conversation

@jbunton-atlassian

When upgrading from Node.js 8 to 10 I hit the behaviour change in #8895. This documentation update would have helped me find the problem faster :)

Also see #25121 for an update to the docs on master.

Thanks :)

Checklist
Original commit message:

    [cpu-profiler] Fix a leak caused by re-logging existing functions.

    Don't re-log all existing functions during StartProcessorIfNotStarted().
    They will already be in the CodeMap attached to the ProfileGenerator and
    re-logging them causes leaks. See the linked bug for more details.

    Bug: v8:8253
    Change-Id: Ibb1a1ab2431c588e8c3a3a9ff714767cdf61a88e
    Reviewed-on: https://chromium-review.googlesource.com/1256763
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{nodejs#56336}

Refs: v8/v8@525b396

PR-URL: nodejs#25041
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Rod Vagg <rod@vagg.org>

This was referenced

Dec 19, 2018

lpinca

lpinca

jasnell

jasnell

MylesBorins pushed a commit that referenced this pull request

Dec 21, 2018
Refs: #8895

PR-URL: #25123
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@addaleax addaleax changed the title update the http.request.setTimeout docs to be accurate [v8.x] update the http.request.setTimeout docs to be accurate

Dec 21, 2018

MylesBorins pushed a commit that referenced this pull request

Dec 26, 2018
Refs: #8895

PR-URL: #25123
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@MylesBorins

rvagg pushed a commit that referenced this pull request

Feb 28, 2019
Refs: #8895

PR-URL: #25123
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Labels

doc

Issues and PRs related to the documentations.

http

Issues or PRs related to the http subsystem.