◐ Shell
clean mode source ↗

v6.17.1 proposal by BethGriggs · Pull Request #26684 · nodejs/node

and others added 7 commits

March 7, 2019 11:26
Currently makes a call to `realpathSync.native` which doesn't exist
on 8.x or lower

PR-URL: #22663
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Fixes: #12572
Refs: #16240

PR-URL: #23746
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #23989
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
In 180f865, the test was changed
so that the `env` argument of `createInternalRepl()` also contained
external environment variables, because keeping them can be necessary
for spawning processes on some systems.

However, this test does not spawn new processes, and relies on the
fact that the environment variables it tests are not already set
(and fails otherwise); therefore, reverting to the original state
should fix this.

Fixes: #21451
Fixes: nodejs/build#1377
Refs: #25219

PR-URL: #25226
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Refs: #24738
Fixes: #25858

PR-URL: #25939
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.

Fixes: #25444

Backport-PR-URL: #26478
PR-URL: #25447
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

richardlau

BridgeAR

@refack refack added the windows

Issues and PRs related to the Windows platform.

label

Apr 2, 2019

BethGriggs added a commit that referenced this pull request

Apr 3, 2019
Notable changes:

- http:
  - fix error check in `Execute()` (Brian White)
    [#25939](#25939)

PR-URL: #26684
Notable changes:

- http:
  - fix error check in `Execute()` (Brian White)
    [#25939](#25939)

PR-URL: #26684

BethGriggs added a commit that referenced this pull request

Apr 3, 2019

BethGriggs added a commit that referenced this pull request

Apr 3, 2019
Notable changes:

- http:
  - fix error check in `Execute()` (Brian White)
    [#25939](#25939)

PR-URL: #26684

BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request

Apr 3, 2019

BethGriggs added a commit to nodejs/nodejs.org that referenced this pull request

Apr 3, 2019

BethGriggs added a commit that referenced this pull request

Apr 4, 2019
Notable changes:

- http:
  - fix error check in `Execute()` (Brian White)
    [#25939](#25939)

PR-URL: #26684

@targos targos deleted the v6.17.1-proposal branch

June 4, 2019 14:09