deps: update V8 to 7.4 by ryzokuken · Pull Request #26685 · nodejs/node

@refack I'd be more than happy to do so. That said, I personally believe it's more suited to the case where commits are made to a repository in org X by a person representing org Y, thus on behalf of the entire organization. For instance, I think upstreaming patches to V8 can be done using this.

Also, I don't think this applies for me anyway:

your commit email and the organization email must be in a domain verified by the organization

That said, I personally believe it's more suited to the case where commits are made to a repository in org X by a person representing org Y, thus on behalf of the entire organization. For instance, I think upstreaming patches to V8 can be done using this.

Yeah, it's worth thinking about and discussing some more. As I see it, it's useful as a way to disclaim changes that are not original work by the commiter...

Actually the designation should probably be on-behalf-of: @v8 <about@v8.dev>

Actually the designation should probably be on-behalf-of: @v8 about@v8.dev

@refack this sounds much closer to the real situation, and I wholeheartedly agree on discussing it further. For now, I'll add on-behalf-of: @v8 <about@v8.dev> to the commits picked up from V8 directly having no real changes done by us.

BTW, I just realized that the following don't hold up for me:

• you must be a member of the organization indicated in the trailer
• your commit email and the organization email must be in a domain verified by the organization

Because of these, I don't think I can make commits on "behalf of" V8. I will pick this up with the V8 team.

segfault on LinuxONE. Maybe because of f1d3b41 ?

Yeah, we probably need to cherry-pick other commits. There are some with a message like " Prepare for changing kTaggedSize"

FYI: I'm strongly considering deprecating the use of pure numbers as values for GYP3 (I want it to be pure strings)...
So in python we might want to use

def b(opt):
	return 'true' if opt else ''

this way in the .gyp we can do:

	conditions: [
		["opt", {}, {}],
		["not opt2", {}, {}],
	],

but I need to think about this some more.

BTW: what the tl;dr about the timeline for landing this?

BTW: what the tl;dr about the timeline for landing this?

ASAP to have it in v12 release candidates

Weird, both Windows builders failed git commands.
FreeBSD was disconnected while running tests.

macOS and AIX were already failing before the cherry-picks.
/cc @nodejs/platform-macos @nodejs/platform-aix

BTW, this version of V8 breaks our V8-CI because: run-tests.py: error: no such option: --junitout