◐ Shell
clean mode source ↗

test: deflake test-tls-sni-option by sam-github · Pull Request #27300 · nodejs/node

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Apr 18, 2019

@sam-github sam-github added the wip

Issues and PRs that are still a work in progress.

label

Apr 19, 2019

@sam-github sam-github removed the wip

Issues and PRs that are still a work in progress.

label

Apr 23, 2019
Let .end() propogate from client, to server, and back, before
considering the test complete. Also, remove the test vector and exit
handling in favour of running all the tests in parallel and using
common.must/mustNotCall().

gireeshpunathil

sam-github added a commit that referenced this pull request

Apr 25, 2019
Let .end() propogate from client, to server, and back, before
considering the test complete. Also, remove the test vector and exit
handling in favour of running all the tests in parallel and using
common.must/mustNotCall().

PR-URL: #27300
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

lpinca added a commit to lpinca/node that referenced this pull request

Apr 26, 2019

targos pushed a commit that referenced this pull request

Apr 27, 2019
Let .end() propogate from client, to server, and back, before
considering the test complete. Also, remove the test vector and exit
handling in favour of running all the tests in parallel and using
common.must/mustNotCall().

PR-URL: #27300
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

Trott pushed a commit to Trott/io.js that referenced this pull request

Apr 30, 2019
Refs: nodejs#27300

PR-URL: nodejs#27425
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

lpinca added a commit to lpinca/node that referenced this pull request

May 1, 2019
- Run all tests in parallel.
- Move `socket.end()` call to client.
- Use `common.mustCall()` and `common.mustNotCall()`.

Fixes: nodejs#27219
Refs: nodejs#27300

Trott pushed a commit to Trott/io.js that referenced this pull request

May 2, 2019
- Run all tests in parallel.
- Move `socket.end()` call to client.
- Use `common.mustCall()` and `common.mustNotCall()`.

Fixes: nodejs#27219
Refs: nodejs#27300

PR-URL: nodejs#27426
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

targos pushed a commit that referenced this pull request

May 4, 2019
Refs: #27300

PR-URL: #27425
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

targos pushed a commit that referenced this pull request

May 4, 2019
- Run all tests in parallel.
- Move `socket.end()` call to client.
- Use `common.mustCall()` and `common.mustNotCall()`.

Fixes: #27219
Refs: #27300

PR-URL: #27426
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>