◐ Shell
clean mode source ↗

test: fix ineffective error tests by shisama · Pull Request #27333 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added addons

Issues and PRs related to native addons.

test

Issues and PRs related to the tests.

labels

Apr 21, 2019 
Fix tests whether errors are thrown correctly
because they are successful when error doesn't get thrown.

BridgeAR

BridgeAR

@shisama

BridgeAR

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 23, 2019

danbev pushed a commit that referenced this pull request

Apr 24, 2019 
Fix tests whether errors are thrown correctly
because they are successful when error doesn't get thrown.

PR-URL: #27333
Fixes: #26385
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@shisama shisama deleted the test-ineffective-errors branch

April 24, 2019 12:43

targos pushed a commit that referenced this pull request

Apr 27, 2019 
Fix tests whether errors are thrown correctly
because they are successful when error doesn't get thrown.

PR-URL: #27333
Fixes: #26385
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>