◐ Shell
clean mode source ↗

dgram: change 'this' to 'self' for 'isConnected' · Pull Request #27338 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added the dgram

Issues and PRs related to the dgram subsystem / UDP.

label

Apr 22, 2019 
The function 'isConnected' is directly called by many 'Socket' instance,
so we shouldn't directly use 'this' because 'this' will be the self of
function itself, and we should use 'self' as the instance of 'Socket'
function.

@ghost ghost changed the title lib: change 'this' to 'self' for 'isConnected' dgram: change 'this' to 'self' for 'isConnected'

Apr 22, 2019

santigimeno

joyeecheung

@ZYSzys ZYSzys added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 22, 2019

benjamingr

Trott pushed a commit to Trott/io.js that referenced this pull request

Apr 24, 2019 
The function 'isConnected' is directly called by many 'Socket' instance,
so we shouldn't directly use 'this' because 'this' will be the self of
function itself, and we should use 'self' as the instance of 'Socket'
function.

PR-URL: nodejs#27338
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

@ghost ghost deleted the BugFix branch

April 24, 2019 23:35

targos pushed a commit that referenced this pull request

Apr 27, 2019 
The function 'isConnected' is directly called by many 'Socket' instance,
so we shouldn't directly use 'this' because 'this' will be the self of
function itself, and we should use 'self' as the instance of 'Socket'
function.

PR-URL: #27338
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>