◐ Shell
clean mode source ↗

test: make test-worker-esm-missing-main more robust by Trott · Pull Request #27340 · nodejs/node

test-worker-esm-missing-main failed in CI recently in a way that
suggests that maybe the `does-not-exist.js` file did in fact exist.
Maybe that isn't what happened at all, but let's rule it out by changing
the use of `does-not-exist.js` from a file expected to be missing from
the current working directory to a file in the temp directory, which the
test will remove and recreate at the outset.

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Apr 22, 2019

BethGriggs

@Trott Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 23, 2019

Trott added a commit to Trott/io.js that referenced this pull request

Apr 24, 2019
test-worker-esm-missing-main failed in CI recently in a way that
suggests that maybe the `does-not-exist.js` file did in fact exist.
Maybe that isn't what happened at all, but let's rule it out by changing
the use of `does-not-exist.js` from a file expected to be missing from
the current working directory to a file in the temp directory, which the
test will remove and recreate at the outset.

PR-URL: nodejs#27340
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

targos pushed a commit that referenced this pull request

Apr 27, 2019
test-worker-esm-missing-main failed in CI recently in a way that
suggests that maybe the `does-not-exist.js` file did in fact exist.
Maybe that isn't what happened at all, but let's rule it out by changing
the use of `does-not-exist.js` from a file expected to be missing from
the current working directory to a file in the temp directory, which the
test will remove and recreate at the outset.

PR-URL: #27340
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

@Trott Trott deleted the missing-esm branch

January 13, 2022 22:51