◐ Shell
clean mode source ↗

util: improve symbol to string tag by BridgeAR · Pull Request #27342 · nodejs/node

BridgeAR

added 2 commits

April 22, 2019 14:28
Only special handle `Symbol.toStringTag` if the property is not
enumerable or not the own property of the inspected object.
The function is actually a getter, not a setter.

benjamingr

addaleax

@BridgeAR BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 22, 2019

danbev pushed a commit that referenced this pull request

Apr 25, 2019 
Only special handle `Symbol.toStringTag` if the property is not
enumerable or not the own property of the inspected object.

PR-URL: #27342
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

danbev pushed a commit that referenced this pull request

Apr 25, 2019 
The function is actually a getter, not a setter.

PR-URL: #27342
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos pushed a commit that referenced this pull request

Apr 27, 2019 
Only special handle `Symbol.toStringTag` if the property is not
enumerable or not the own property of the inspected object.

PR-URL: #27342
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

targos pushed a commit that referenced this pull request

Apr 27, 2019 
The function is actually a getter, not a setter.

PR-URL: #27342
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

@BridgeAR BridgeAR deleted the improve-symbol-to-string-tag branch

January 20, 2020 12:02