◐ Shell
clean mode source ↗

test: refactor and deflake test-tls-sni-server-client by lpinca · Pull Request #27426 · nodejs/node

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Apr 26, 2019

sam-github

Trott

- Run all tests in parallel.
- Move `socket.end()` call to client.
- Use `common.mustCall()` and `common.mustNotCall()`.

Fixes: nodejs#27219
Refs: nodejs#27300

Trott pushed a commit to Trott/io.js that referenced this pull request

May 2, 2019
- Run all tests in parallel.
- Move `socket.end()` call to client.
- Use `common.mustCall()` and `common.mustNotCall()`.

Fixes: nodejs#27219
Refs: nodejs#27300

PR-URL: nodejs#27426
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@lpinca lpinca deleted the deflake/test-tls-sni-server-client branch

May 4, 2019 07:44

targos pushed a commit that referenced this pull request

May 4, 2019
- Run all tests in parallel.
- Move `socket.end()` call to client.
- Use `common.mustCall()` and `common.mustNotCall()`.

Fixes: #27219
Refs: #27300

PR-URL: #27426
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

This was referenced

May 7, 2019