[v10.x] doc,n-api: update matrix for N-API version 4 by richardlau · Pull Request #27832 · nodejs/node
-
-
Notifications
You must be signed in to change notification settings - Fork 35.7k
Conversation
The N-API version was bumped to 4 for Node.js 10 in
#25633
Refs: #25633
This should land in the release with the above referenced PR.
cc @nodejs/lts @nodejs/n-api
Checklist
-
make -j4 test(UNIX), orvcbuild test(Windows) passes - documentation is changed or added
- commit message follows commit guidelines
Once this lands in a Node.js 10.x release (i.e. the actual version of Node.js 10 that first supports N-API version 4 is known) a follow up PR needs to add that information to the N-API docs on master.
@richardlau I assume the REPLACEME's are handled as part of the release process right?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BethGriggs pushed a commit that referenced this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters