◐ Shell
clean mode source ↗

net: make writeAfterFIN() return false by lpinca · Pull Request #27996 · nodejs/node

addaleax

If `false` is not returned a readable stream piped into the socket
might continue reading indefinitely until the process goes out of
memory.

addaleax

approved these changes May 31, 2019

@addaleax addaleax added the net

Issues and PRs related to the net subsystem.

label

Jun 2, 2019

@Trott Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jun 3, 2019

danbev pushed a commit that referenced this pull request

Jun 4, 2019 
If `false` is not returned a readable stream piped into the socket
might continue reading indefinitely until the process goes out of
memory.

PR-URL: #27996
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@lpinca lpinca deleted the return/false branch

June 8, 2019 11:46

BridgeAR pushed a commit that referenced this pull request

Jun 17, 2019 
If `false` is not returned a readable stream piped into the socket
might continue reading indefinitely until the process goes out of
memory.

PR-URL: #27996
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>