◐ Shell
clean mode source ↗

fs: add recursive option to rmdir() by cjihrig · Pull Request #29168 · nodejs/node

@nodejs-github-bot added the lib / src

Issues and PRs related to general changes in the lib or src directory.

label

Aug 16, 2019

@bcoe bcoe mentioned this pull request

Aug 17, 2019

4 tasks

@cjihrig cjihrig marked this pull request as ready for review

August 19, 2019 19:09

silverwind

@silverwind silverwind added the semver-minor

PRs that contain new features and should be released in the next minor version.

label

Aug 19, 2019

silverwind

Trott

Trott

Trott

@cjihrig cjihrig added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Aug 20, 2019

bcoe

bcoe approved these changes Aug 20, 2019

MylesBorins

gengjiawen

Trott pushed a commit that referenced this pull request

Aug 23, 2019
This commit adds a recursive option to fs.rmdir(),
fs.rmdirSync(), and fs.promises.rmdir(). The implementation
is a port of the npm module rimraf.

PR-URL: #29168
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

@iansu iansu mentioned this pull request

Aug 23, 2019

5 tasks

BridgeAR pushed a commit that referenced this pull request

Sep 3, 2019
This commit adds a recursive option to fs.rmdir(),
fs.rmdirSync(), and fs.promises.rmdir(). The implementation
is a port of the npm module rimraf.

PR-URL: #29168
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

BridgeAR added a commit that referenced this pull request

Sep 3, 2019
Notable changes:

* deps:
  * Update npm to 6.10.3 (isaacs)
    #29023
* fs:
  * Add recursive option to rmdir() (cjihrig)
    #29168
  * Allow passing true to emitClose option (Giorgos Ntemiris)
    #29212
  * Add \*timeNs properties to BigInt Stats objects (Joyee Cheung)
    #21387
* net:
  * Allow reading data into a static buffer (Brian White)
    #25436

PR-URL: #29429

BridgeAR added a commit that referenced this pull request

Sep 4, 2019
Notable changes:

* deps:
  * Update npm to 6.10.3 (isaacs)
    #29023
* fs:
  * Add recursive option to rmdir() (cjihrig)
    #29168
  * Allow passing true to emitClose option (Giorgos Ntemiris)
    #29212
  * Add \*timeNs properties to BigInt Stats objects (Joyee Cheung)
    #21387
* net:
  * Allow reading data into a static buffer (Brian White)
    #25436

PR-URL: #29429

BridgeAR added a commit that referenced this pull request

Sep 4, 2019
Notable changes:

* deps:
  * Update npm to 6.10.3 (isaacs)
    #29023
* fs:
  * Add recursive option to rmdir() (cjihrig)
    #29168
  * Allow passing true to emitClose option (Giorgos Ntemiris)
    #29212
  * Add \*timeNs properties to BigInt Stats objects (Joyee Cheung)
    #21387
* net:
  * Allow reading data into a static buffer (Brian White)
    #25436

PR-URL: #29429

@iansu iansu mentioned this pull request

Sep 6, 2019

@ntwb ntwb mentioned this pull request

Nov 28, 2019

@bcoe bcoe mentioned this pull request

Jul 11, 2020

@bcoe bcoe mentioned this pull request

Sep 13, 2020

4 tasks