◐ Shell
clean mode source ↗

vm: lazily initialize primordials for vm contexts by joyeecheung · Pull Request #31738 · nodejs/node

Lazily initialize primordials when cross-context support for
builtins is needed to fix the performance regression in context
creation.

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

vm

Issues and PRs related to the vm subsystem.

labels

Feb 11, 2020

joyeecheung

joyeecheung

@joyeecheung

joyeecheung

addaleax

devnexen

@addaleax addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Feb 13, 2020

joyeecheung added a commit that referenced this pull request

Feb 19, 2020
Lazily initialize primordials when cross-context support for
builtins is needed to fix the performance regression in context
creation.

PR-URL: #31738
Fixes: #29842
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>

codebytere pushed a commit that referenced this pull request

Feb 27, 2020
Lazily initialize primordials when cross-context support for
builtins is needed to fix the performance regression in context
creation.

PR-URL: #31738
Fixes: #29842
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>

targos pushed a commit to targos/node that referenced this pull request

Apr 25, 2020
Lazily initialize primordials when cross-context support for
builtins is needed to fix the performance regression in context
creation.

PR-URL: nodejs#31738
Fixes: nodejs#29842
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>

targos pushed a commit that referenced this pull request

Apr 28, 2020
Lazily initialize primordials when cross-context support for
builtins is needed to fix the performance regression in context
creation.

PR-URL: #31738
Fixes: #29842
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>