◐ Shell
clean mode source ↗

test: remove common.PORT from test-net-write-callbacks.js by Trott · Pull Request #31839 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Feb 18, 2020

addaleax

@Trott Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Feb 18, 2020

codebytere

richardlau

Switch test-net-write-callbacks.js from common.PORT to a port assigned
by the operating system.

PR-URL: nodejs#31839
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

@Trott Trott deleted the test-net-write-callbacks.js branch

February 20, 2020 02:59

codebytere pushed a commit that referenced this pull request

Feb 27, 2020 
Switch test-net-write-callbacks.js from common.PORT to a port assigned
by the operating system.

PR-URL: #31839
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

codebytere pushed a commit that referenced this pull request

Mar 15, 2020 
Switch test-net-write-callbacks.js from common.PORT to a port assigned
by the operating system.

PR-URL: #31839
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

codebytere pushed a commit that referenced this pull request

Mar 17, 2020 
Switch test-net-write-callbacks.js from common.PORT to a port assigned
by the operating system.

PR-URL: #31839
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

codebytere pushed a commit that referenced this pull request

Mar 30, 2020 
Switch test-net-write-callbacks.js from common.PORT to a port assigned
by the operating system.

PR-URL: #31839
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>