◐ Shell
clean mode source ↗

test: use InitializeNodeWithArgs in cctest by addaleax · Pull Request #32406 · nodejs/node

nodejs-github-bot

@addaleax

@nodejs-github-bot added the test

Issues and PRs related to the tests.

label

Mar 21, 2020

@addaleax addaleax added c++

Issues and PRs that require attention from people who are familiar with C++.

and removed test

Issues and PRs related to the tests.

labels

Mar 21, 2020

gengjiawen

mmarchini

@addaleax addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 21, 2020

devnexen

mmarchini pushed a commit that referenced this pull request

Mar 23, 2020 
Refs: d7f1107
Fixes: #30257

PR-URL: #32406
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@addaleax addaleax deleted the cctest-InitializeNodeWithArgs branch

March 23, 2020 18:02

addaleax added a commit to addaleax/node that referenced this pull request

Sep 23, 2020 
Refs: nodejs@d7f1107
Fixes: nodejs#30257

PR-URL: nodejs#32406
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

addaleax added a commit that referenced this pull request

Sep 23, 2020 
Refs: d7f1107
Fixes: #30257

Backport-PR-URL: #35241
PR-URL: #32406
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>