◐ Shell
clean mode source ↗

vm: throw error when duplicated exportNames in SyntheticModule by himself65 · Pull Request #32810 · nodejs/node

nodejs-github-bot

Skip to content

Navigation Menu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@himself65

Fixes: #32806

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

SimenB

@himself65

This comment has been minimized.

targos

devsnek

devsnek

@nodejs-github-bot

@himself65 himself65 changed the title vm: avoid duplicated exportNames on SyntheticModule vm: throw error when duplicated exportNames in SyntheticModule

Apr 13, 2020

SimenB

SimenB

addaleax

@addaleax addaleax added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 27, 2020

@nodejs-github-bot

targos

himself65 added a commit that referenced this pull request

Apr 28, 2020 
Fixes: #32806

PR-URL: #32810
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

@himself65

targos pushed a commit that referenced this pull request

May 4, 2020 
Fixes: #32806

PR-URL: #32810
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

targos pushed a commit that referenced this pull request

May 7, 2020 
Fixes: #32806

PR-URL: #32810
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

targos pushed a commit that referenced this pull request

May 13, 2020 
Fixes: #32806

PR-URL: #32810
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

Labels

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

vm

Issues and PRs related to the vm subsystem.