◐ Shell
clean mode source ↗

lib: fix validateport error message when allowZero is false by rickyes · Pull Request #32861 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added the errors

Issues and PRs related to JavaScript errors originated in Node.js core.

label

Apr 15, 2020

@rickyes rickyes changed the title lib: fix validateport error message when allowZero = false lib: fix validateport error message when allowZero is false

Apr 15, 2020

himself65

@rickyes

himself65

bnoordhuis

BridgeAR

addaleax pushed a commit that referenced this pull request

Apr 28, 2020 
PR-URL: #32861
Fixes: #32857
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@rickyes rickyes deleted the fix-validateport-errmsg branch

April 28, 2020 17:24

targos pushed a commit that referenced this pull request

May 4, 2020 
PR-URL: #32861
Fixes: #32857
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos pushed a commit that referenced this pull request

May 7, 2020 
PR-URL: #32861
Fixes: #32857
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos pushed a commit that referenced this pull request

May 13, 2020 
PR-URL: #32861
Fixes: #32857
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>