◐ Shell
clean mode source ↗

[v14.x] http2: use and support non-empty DATA frame with END_STREAM flag by clshortfuse · Pull Request #34838 · nodejs/node

clshortfuse

@nodejs-github-bot nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

lib / src

Issues and PRs related to general changes in the lib or src directory.

v14.x labels

Aug 19, 2020

@clshortfuse clshortfuse changed the title http2: use and support non-empty DATA frame with END_STREAM flag http2: (backport v14.x) use and support non-empty DATA frame with END_STREAM flag

Aug 19, 2020

@clshortfuse @MylesBorins

@MylesBorins MylesBorins changed the title http2: (backport v14.x) use and support non-empty DATA frame with END_STREAM flag [v14.x] http2: use and support non-empty DATA frame with END_STREAM flag

Aug 20, 2020

MylesBorins pushed a commit that referenced this pull request

Aug 21, 2020 
Adds support for reading from a stream where the final frame is a
non-empty DATA frame with the END_STREAM flag set, instead of hanging
waiting for another frame. When writing to a stream, uses a
END_STREAM flag on final DATA frame instead of adding an empty
DATA frame.

BREAKING: http2 client now expects servers to properly support
END_STREAM flag

Fixes: #31309
Fixes: #33891
Refs: https://nghttp2.org/documentation/types.html#c.nghttp2_on_data_chunk_recv_callback

PR-URL: #33875
Backport-PR-URL: #34838
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

This was referenced

Aug 22, 2020