◐ Shell
clean mode source ↗

crypto: fixup scrypt regressions by jasnell · Pull Request #35821 · nodejs/node

nodejs-github-bot

Fixes a handful of regressions in scrypt support following
the refactor.

Fixes: nodejs#35815

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

lib / src

Issues and PRs related to general changes in the lib or src directory.

labels

Oct 26, 2020

@jasnell jasnell added crypto

Issues and PRs related to the crypto subsystem.

regression

Issues related to regressions.

request-ci

Add this label to start a Jenkins CI on a PR.

labels

Oct 26, 2020

addaleax

@jasnell

@jasnell jasnell added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Oct 26, 2020

tniessen

mcollina

@aduh95 aduh95 added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Oct 30, 2020

nodejs-github-bot pushed a commit that referenced this pull request

Oct 30, 2020 
Fixes a handful of regressions in scrypt support following
the refactor.

Fixes: #35815

PR-URL: #35821
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

targos pushed a commit that referenced this pull request

Nov 3, 2020 
Fixes a handful of regressions in scrypt support following
the refactor.

Fixes: #35815

PR-URL: #35821
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

tniessen added a commit to tniessen/node that referenced this pull request

Nov 4, 2020

lpinca pushed a commit that referenced this pull request

Nov 5, 2020 
PR-URL: #35972
Refs: #35821
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

danielleadams pushed a commit that referenced this pull request

Nov 9, 2020 
PR-URL: #35972
Refs: #35821
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>