◐ Shell
clean mode source ↗

fs: remove unused assignment by Trott · Pull Request #35882 · nodejs/node

nodejs-github-bot

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@Trott

@Trott Trott commented

Oct 30, 2020

Copy link Copy Markdown

Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
bricss reacted with thumbs up emoji

@nodejs-github-bot nodejs-github-bot added the fs

Issues and PRs related to the fs subsystem / file system.

label

Oct 30, 2020

@Trott Trott added the request-ci

Add this label to start a Jenkins CI on a PR.

label

Oct 30, 2020

@github-actions github-actions Bot removed the request-ci

Add this label to start a Jenkins CI on a PR.

label

Oct 30, 2020 
PR-URL: nodejs#35882
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

@Trott

Trott commented

Nov 7, 2020

Copy link Copy Markdown

Member Author

Landed in 1d525f5

@Trott Trott merged commit 1d525f5 into nodejs:master

Nov 7, 2020

@Trott Trott deleted the unused-options branch

November 7, 2020 06:00

danielleadams pushed a commit that referenced this pull request

Nov 9, 2020 
PR-URL: #35882
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

@danielleadams danielleadams mentioned this pull request

Nov 9, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@watilde watilde watilde approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

fs

Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott @nodejs-github-bot @watilde @cjihrig @targos