◐ Shell
clean mode source ↗

benchmark: remove modules that require intl by richardlau · Pull Request #35968 · nodejs/node

nodejs-github-bot

`inspector` and `trace_events` will throw errors if Node.js has been
compiled with `--without-intl`.

Refs: nodejs#35816

@nodejs-github-bot added the benchmark

Issues and PRs related to the benchmark subsystem.

label

Nov 4, 2020

@richardlau richardlau added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Nov 4, 2020

gireeshpunathil

HarshithaKP

@Flarna Flarna added fast-track

PRs that do not need to wait for 72 hours to land.

commit-queue

Add this label to land a pull request using GitHub Actions.

and removed commit-queue-failed

An error occurred while landing this pull request using GitHub Actions.

labels

Nov 5, 2020

nodejs-github-bot pushed a commit that referenced this pull request

Nov 5, 2020 
`inspector` and `trace_events` will throw errors if Node.js has been
compiled with `--without-intl`.

Refs: #35816

PR-URL: #35968
Fixes: #35962
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

danielleadams pushed a commit that referenced this pull request

Nov 9, 2020 
`inspector` and `trace_events` will throw errors if Node.js has been
compiled with `--without-intl`.

Refs: #35816

PR-URL: #35968
Fixes: #35962
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

BethGriggs pushed a commit that referenced this pull request

Dec 9, 2020 
`inspector` and `trace_events` will throw errors if Node.js has been
compiled with `--without-intl`.

Refs: #35816

PR-URL: #35968
Fixes: #35962
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

BethGriggs pushed a commit that referenced this pull request

Dec 10, 2020 
`inspector` and `trace_events` will throw errors if Node.js has been
compiled with `--without-intl`.

Refs: #35816

PR-URL: #35968
Fixes: #35962
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

BethGriggs pushed a commit that referenced this pull request

Dec 15, 2020 
`inspector` and `trace_events` will throw errors if Node.js has been
compiled with `--without-intl`.

Refs: #35816

PR-URL: #35968
Fixes: #35962
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>