◐ Shell
clean mode source ↗

fs: replace finally with PromisePrototypeFinally by baruchiro · Pull Request #35995 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added the fs

Issues and PRs related to the fs subsystem / file system.

label

Nov 6, 2020

benjamingr

@baruchiro baruchiro changed the title Suggested refactor by #35993 fs: replace finally with PromisePrototypeFinally

Nov 7, 2020

@baruchiro

@aduh95 aduh95 added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Nov 8, 2020

@aduh95 aduh95 added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Nov 9, 2020

nodejs-github-bot pushed a commit that referenced this pull request

Nov 9, 2020 
#35993 (comment)

PR-URL: #35995
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

danielleadams pushed a commit that referenced this pull request

Nov 10, 2020 
#35993 (comment)

PR-URL: #35995
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Dec 9, 2020 
#35993 (comment)

PR-URL: #35995
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Dec 10, 2020 
#35993 (comment)

PR-URL: #35995
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BethGriggs pushed a commit that referenced this pull request

Dec 15, 2020 
#35993 (comment)

PR-URL: #35995
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>