tls: use the most recently added matching SecureContext in default SN… by mkrawczuk · Pull Request #36072 · nodejs/node
Conversation
Sorry, ruined the previous PR (#34638) with a merge.
Fixes: #34110
Checklist
-
make -j4 test(UNIX), orvcbuild test(Windows) passes - tests and/or benchmarks are included
- documentation is changed or added
- commit message follows commit guidelines
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit: we could be more strict here and assert that these are equal depending on the current step, same for the other conditional below
Did a clear rebase, because the previous one failed. @Trott you might want to request another CI.
PR-URL: nodejs#36072 Fixes: nodejs#34110 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
ruyadorno pushed a commit that referenced this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters