◐ Shell
clean mode source ↗

async_hooks: eliminate native PromiseHook by Qard · Pull Request #39135 · nodejs/node

Qard

@Qard added c++

Issues and PRs that require attention from people who are familiar with C++.

async_wrap async_hooks

Issues and PRs related to the async hooks subsystem.

trace_events

Issues and PRs related to V8, Node.js core, and userspace code trace events.

labels

Jun 24, 2021

@Qard Qard added the request-ci

Add this label to start a Jenkins CI on a PR.

label

Jun 24, 2021

Hbutlercapone

Stephen Belanger added 2 commits

July 5, 2021 15:16

@Qard Qard added the request-ci

Add this label to start a Jenkins CI on a PR.

label

Jul 5, 2021

@Qard Qard added the request-ci

Add this label to start a Jenkins CI on a PR.

label

Jul 5, 2021

@Qard Qard added the request-ci

Add this label to start a Jenkins CI on a PR.

label

Jul 6, 2021

richardlau pushed a commit that referenced this pull request

Jul 29, 2021 
PR-URL: #39135
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

richardlau pushed a commit that referenced this pull request

Jul 29, 2021 
PR-URL: #39135
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

richardlau pushed a commit that referenced this pull request

Jul 29, 2021 
PR-URL: #39135
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

richardlau pushed a commit that referenced this pull request

Jul 29, 2021 
Promise handling is special-cased for domains and trace_events.
Domains must not add the `domain` property to promises in other
contexts, and trace_events must be emitted from JavaScript as
promises no longer have an AsyncWrap type attached to them.

PR-URL: #39135
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

BethGriggs pushed a commit that referenced this pull request

Jul 29, 2021 
PR-URL: #39135
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

BethGriggs pushed a commit that referenced this pull request

Jul 29, 2021 
PR-URL: #39135
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

BethGriggs pushed a commit that referenced this pull request

Jul 29, 2021 
PR-URL: #39135
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

BethGriggs pushed a commit that referenced this pull request

Jul 29, 2021 
Promise handling is special-cased for domains and trace_events.
Domains must not add the `domain` property to promises in other
contexts, and trace_events must be emitted from JavaScript as
promises no longer have an AsyncWrap type attached to them.

PR-URL: #39135
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

@Qard Qard mentioned this pull request

Aug 12, 2021

Qard pushed a commit to Qard/node that referenced this pull request

Aug 12, 2021 
PR-URL: nodejs#39135
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

Qard pushed a commit to Qard/node that referenced this pull request

Aug 12, 2021 
PR-URL: nodejs#39135
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

Qard pushed a commit to Qard/node that referenced this pull request

Aug 12, 2021 
PR-URL: nodejs#39135
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

Qard pushed a commit to Qard/node that referenced this pull request

Aug 12, 2021 
Promise handling is special-cased for domains and trace_events.
Domains must not add the `domain` property to promises in other
contexts, and trace_events must be emitted from JavaScript as
promises no longer have an AsyncWrap type attached to them.

PR-URL: nodejs#39135
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

targos pushed a commit that referenced this pull request

Aug 29, 2021 
PR-URL: #39135
Backport-PR-URL: #39742
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

targos pushed a commit that referenced this pull request

Aug 29, 2021 
PR-URL: #39135
Backport-PR-URL: #39742
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

targos pushed a commit that referenced this pull request

Aug 29, 2021 
PR-URL: #39135
Backport-PR-URL: #39742
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

targos pushed a commit that referenced this pull request

Aug 29, 2021 
Promise handling is special-cased for domains and trace_events.
Domains must not add the `domain` property to promises in other
contexts, and trace_events must be emitted from JavaScript as
promises no longer have an AsyncWrap type attached to them.

PR-URL: #39135
Backport-PR-URL: #39742
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

MylesBorins pushed a commit that referenced this pull request

Aug 31, 2021 
PR-URL: #39135
Backport-PR-URL: #39742
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

MylesBorins pushed a commit that referenced this pull request

Aug 31, 2021 
PR-URL: #39135
Backport-PR-URL: #39742
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

MylesBorins pushed a commit that referenced this pull request

Aug 31, 2021 
PR-URL: #39135
Backport-PR-URL: #39742
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>