◐ Shell
clean mode source ↗

msi: migrate to WiX4 by StefanStojanovic · Pull Request #45943 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added build

Issues and PRs related to build files or the CI.

doc

Issues and PRs related to the documentations.

install

Issues and PRs related to the installers.

meta

Issues and PRs related to the general management of the project.

needs-ci

PRs that need a full CI run.

tools

Issues and PRs related to the tools directory.

windows

Issues and PRs related to the Windows platform.

labels

Dec 22, 2022

StefanStojanovic added a commit to JaneaSystems/build that referenced this pull request

Mar 2, 2023 
This is required to migrate from WiX3 to WiX4 for building the Node msi.

Refs: nodejs/node#45943

StefanStojanovic added a commit to JaneaSystems/build that referenced this pull request

Mar 8, 2023 
This is required to migrate from WiX3 to WiX4 for building the Node msi.

Refs: nodejs/node#45943
PR-URL: nodejs#3211
Reviewed-By: Richard Lau <rlau@redhat.com>

StefanStojanovic added a commit to nodejs/build that referenced this pull request

Mar 8, 2023 
This is required to migrate from WiX3 to WiX4 for building the Node msi.

Refs: nodejs/node#45943
PR-URL: #3211
Reviewed-By: Richard Lau <rlau@redhat.com>

joaocgreis

richardlau

StefanStojanovic added a commit to JaneaSystems/node that referenced this pull request

Mar 23, 2023

StefanStojanovic added a commit to JaneaSystems/build that referenced this pull request

Mar 23, 2023

StefanStojanovic added a commit to JaneaSystems/build that referenced this pull request

Mar 23, 2023

StefanStojanovic added a commit to JaneaSystems/build that referenced this pull request

Mar 27, 2023 
Refs: nodejs/node#45943
PR-URL: nodejs#3251
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ulises Gascón <UlisesGascon@users.noreply.github.com>

StefanStojanovic added a commit to nodejs/build that referenced this pull request

Mar 27, 2023 
Refs: nodejs/node#45943
PR-URL: #3251
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ulises Gascón <UlisesGascon@users.noreply.github.com>

RafaelGSS pushed a commit that referenced this pull request

Apr 5, 2023 
To be able to build x86, x64, and ARM64 MSI installers with the same WiX
version, migration to WiX4 is required.

PR-URL: #45943
Refs: nodejs/build#2540
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

RafaelGSS added a commit that referenced this pull request

Apr 6, 2023 
Notable changes:

events:
  * (SEMVER-MINOR) add getMaxListeners method (Khafra) #47039
lib:
  * (SEMVER-MINOR) add tracing channel to diagnostics\_channel (Stephen Belanger)
msi:
  * (SEMVER-MINOR) migrate to WiX4 (Stefan Stojanovic) #45943
node-api:
  * (SEMVER-MINOR) deprecate napi\_module\_register (Vladimir Morozov) #46319
stream:
  * (SEMVER-MINOR) add setter & getter for default highWaterMark (Robert Nagy) #46929
url:
  * (SEMVER-MINOR) implement URL.canParse (Khafra) #47179
wasi:
  * (SEMVER-MINOR) no longer require flag to enable wasi (Michael Dawson) #47286

PR-URL: TBD

RafaelGSS added a commit that referenced this pull request

Apr 6, 2023 
Notable changes:

events:
  * (SEMVER-MINOR) add getMaxListeners method (Khafra) #47039
lib:
  * (SEMVER-MINOR) add tracing channel to diagnostics\_channel (Stephen Belanger)
msi:
  * (SEMVER-MINOR) migrate to WiX4 (Stefan Stojanovic) #45943
node-api:
  * (SEMVER-MINOR) deprecate napi\_module\_register (Vladimir Morozov) #46319
stream:
  * (SEMVER-MINOR) add setter & getter for default highWaterMark (Robert Nagy) #46929
url:
  * (SEMVER-MINOR) implement URL.canParse (Khafra) #47179
wasi:
  * (SEMVER-MINOR) no longer require flag to enable wasi (Michael Dawson) #47286

PR-URL: TBD

RafaelGSS added a commit that referenced this pull request

Apr 6, 2023 
Notable changes:

events:
  * (SEMVER-MINOR) add getMaxListeners method (Khafra) #47039
lib:
  * (SEMVER-MINOR) add tracing channel to diagnostics\_channel (Stephen Belanger)
msi:
  * (SEMVER-MINOR) migrate to WiX4 (Stefan Stojanovic) #45943
node-api:
  * (SEMVER-MINOR) deprecate napi\_module\_register (Vladimir Morozov) #46319
stream:
  * (SEMVER-MINOR) add setter & getter for default highWaterMark (Robert Nagy) #46929
url:
  * (SEMVER-MINOR) implement URL.canParse (Khafra) #47179
wasi:
  * (SEMVER-MINOR) no longer require flag to enable wasi (Michael Dawson) #47286

PR-URL: #47441

RafaelGSS added a commit that referenced this pull request

Apr 6, 2023 
Notable changes:

events:
  * (SEMVER-MINOR) add getMaxListeners method (Khafra) #47039
lib:
  * (SEMVER-MINOR) add tracing channel to diagnostics\_channel (Stephen Belanger)
msi:
  * (SEMVER-MINOR) migrate to WiX4 (Stefan Stojanovic) #45943
node-api:
  * (SEMVER-MINOR) deprecate napi\_module\_register (Vladimir Morozov) #46319
stream:
  * (SEMVER-MINOR) add setter & getter for default highWaterMark (Robert Nagy) #46929
url:
  * (SEMVER-MINOR) implement URL.canParse (Khafra) #47179
wasi:
  * (SEMVER-MINOR) no longer require flag to enable wasi (Michael Dawson) #47286

PR-URL: #47441

RafaelGSS pushed a commit that referenced this pull request

Apr 7, 2023 
To be able to build x86, x64, and ARM64 MSI installers with the same WiX
version, migration to WiX4 is required.

PR-URL: #45943
Refs: nodejs/build#2540
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

RafaelGSS added a commit that referenced this pull request

Apr 7, 2023 
Notable changes:

events:
  * (SEMVER-MINOR) add getMaxListeners method (Khafra) #47039
lib:
  * (SEMVER-MINOR) add tracing channel to diagnostics\_channel (Stephen Belanger)
msi:
  * (SEMVER-MINOR) migrate to WiX4 (Stefan Stojanovic) #45943
node-api:
  * (SEMVER-MINOR) deprecate napi\_module\_register (Vladimir Morozov) #46319
stream:
  * (SEMVER-MINOR) add setter & getter for default highWaterMark (Robert Nagy) #46929
url:
  * (SEMVER-MINOR) implement URL.canParse (Khafra) #47179
wasi:
  * (SEMVER-MINOR) no longer require flag to enable wasi (Michael Dawson) #47286

PR-URL: #47441

RafaelGSS added a commit that referenced this pull request

Apr 8, 2023 
Notable changes:

events:
  * (SEMVER-MINOR) add getMaxListeners method (Khafra) #47039
lib:
  * (SEMVER-MINOR) add tracing channel to diagnostics\_channel (Stephen Belanger)
msi:
  * (SEMVER-MINOR) migrate to WiX4 (Stefan Stojanovic) #45943
node-api:
  * (SEMVER-MINOR) deprecate napi\_module\_register (Vladimir Morozov) #46319
stream:
  * (SEMVER-MINOR) add setter & getter for default highWaterMark (Robert Nagy) #46929
url:
  * (SEMVER-MINOR) implement URL.canParse (Khafra) #47179

PR-URL: #47441

RafaelGSS added a commit that referenced this pull request

Apr 10, 2023 
Notable changes:

events:
  * (SEMVER-MINOR) add getMaxListeners method (Khafra) #47039
lib:
  * (SEMVER-MINOR) add tracing channel to diagnostics\_channel (Stephen Belanger)
msi:
  * (SEMVER-MINOR) migrate to WiX4 (Stefan Stojanovic) #45943
node-api:
  * (SEMVER-MINOR) deprecate napi\_module\_register (Vladimir Morozov) #46319
stream:
  * (SEMVER-MINOR) add setter & getter for default highWaterMark (Robert Nagy) #46929
url:
  * (SEMVER-MINOR) implement URL.canParse (Khafra) #47179
test_runner:
  * (SEMVER-MINOR) expose reporter for use in run api (Chemi Atlow) #47238

PR-URL: #47441
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>

RafaelGSS added a commit that referenced this pull request

Apr 11, 2023 
Notable changes:

events:
  * (SEMVER-MINOR) add getMaxListeners method (Khafra) #47039
lib:
  * (SEMVER-MINOR) add tracing channel to diagnostics\_channel (Stephen Belanger)
msi:
  * (SEMVER-MINOR) migrate to WiX4 (Stefan Stojanovic) #45943
node-api:
  * (SEMVER-MINOR) deprecate napi\_module\_register (Vladimir Morozov) #46319
stream:
  * (SEMVER-MINOR) add setter & getter for default highWaterMark (Robert Nagy) #46929
url:
  * (SEMVER-MINOR) implement URL.canParse (Khafra) #47179
test_runner:
  * (SEMVER-MINOR) expose reporter for use in run api (Chemi Atlow) #47238

PR-URL: #47441
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>

RafaelGSS added a commit that referenced this pull request

Apr 13, 2023 
Notable changes:

events:
  * (SEMVER-MINOR) add getMaxListeners method (Khafra) #47039
lib:
  * (SEMVER-MINOR) add tracing channel to diagnostics\_channel (Stephen Belanger)
msi:
  * (SEMVER-MINOR) migrate to WiX4 (Stefan Stojanovic) #45943
node-api:
  * (SEMVER-MINOR) deprecate napi\_module\_register (Vladimir Morozov) #46319
stream:
  * (SEMVER-MINOR) add setter & getter for default highWaterMark (Robert Nagy) #46929
url:
  * (SEMVER-MINOR) implement URL.canParse (Khafra) #47179
test_runner:
  * (SEMVER-MINOR) expose reporter for use in run api (Chemi Atlow) #47238

PR-URL: #47441
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>