◐ Shell
clean mode source ↗

Revert commits that cause failing tests on Windows CI by Trott · Pull Request #4679 · nodejs/node

Trott

@Trott mentioned this pull request

Jan 13, 2016

@mscdex mscdex added windows

Issues and PRs related to the Windows platform.

fs

Issues and PRs related to the fs subsystem / file system.

module

Issues and PRs related to the module subsystem.

labels

Jan 14, 2016

This was referenced

Jan 14, 2016 
This reverts commit 809bf5e
("change statSync to accessSync in realpathSync").

It was causing tests to fail on Windows CI.

Ref: nodejs#4575
PR-URL: nodejs#4679
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This reverts commit 7c60328.

It is causing CI failures on Windows.

Ref: nodejs#4575
PR-URL: nodejs#4679
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Trott added a commit that referenced this pull request

Jan 16, 2016 
This reverts commit 809bf5e
("change statSync to accessSync in realpathSync").

It was causing tests to fail on Windows CI.

Ref: #4575
PR-URL: #4679
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Trott added a commit that referenced this pull request

Jan 16, 2016 
This reverts commit 7c60328.

It is causing CI failures on Windows.

Ref: #4575
PR-URL: #4679
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

scovetta pushed a commit to scovetta/node that referenced this pull request

Apr 2, 2016 
This reverts commit 809bf5e
("change statSync to accessSync in realpathSync").

It was causing tests to fail on Windows CI.

Ref: nodejs#4575
PR-URL: nodejs#4679
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

scovetta pushed a commit to scovetta/node that referenced this pull request

Apr 2, 2016 
This reverts commit 7c60328.

It is causing CI failures on Windows.

Ref: nodejs#4575
PR-URL: nodejs#4679
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

This was referenced

May 11, 2017

gibfahn added a commit to gibfahn/node that referenced this pull request

May 16, 2017 
PR-URL: nodejs#13015
Fixes: nodejs#12979
Refs: nodejs#4679 (comment)
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

anchnk pushed a commit to anchnk/node that referenced this pull request

May 19, 2017 
PR-URL: nodejs#13015
Fixes: nodejs#12979
Refs: nodejs#4679 (comment)
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Jun 22, 2017 
PR-URL: #13015
Fixes: #12979
Refs: #4679 (comment)
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request

Jul 11, 2017 
PR-URL: #13015
Fixes: #12979
Refs: #4679 (comment)
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@bzoz bzoz mentioned this pull request

Feb 9, 2018

2 tasks