◐ Shell
clean mode source ↗

doc: improve documentation for util.types.isNativeError() by brodo · Pull Request #46840 · nodejs/node

nodejs-github-bot

@nodejs-github-bot added doc

Issues and PRs related to the documentations.

util

Issues and PRs related to the built-in util module.

labels

Feb 25, 2023 
Makes clear what a native error is by linking the spec. Explains that
`instanceof Error` and util.types.isNativeError() are not equivalent.
Give examples for objects that are `instance of Error` but not native
errors and vice versa. Recommends checking for both if one wants to find
out if something is an error.

aduh95

aduh95

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

@aduh95 aduh95 added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 1, 2023 
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>

aduh95

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95

@brodo

BridgeAR

@aduh95 aduh95 added the commit-queue

Add this label to land a pull request using GitHub Actions.

label

Mar 1, 2023

jasnell

Co-authored-by: James M Snell <jasnell@gmail.com>

@aduh95 aduh95 added commit-queue

Add this label to land a pull request using GitHub Actions.

commit-queue-squash

Add this label to instruct the Commit Queue to squash all the PR commits into the first one.

and removed commit-queue-failed

An error occurred while landing this pull request using GitHub Actions.

labels

Mar 18, 2023

RafaelGSS pushed a commit that referenced this pull request

Apr 5, 2023 
Makes clear what a native error is by linking the spec. Explains that
`instanceof Error` and util.types.isNativeError() are not equivalent.
Give examples for objects that are `instance of Error` but not native
errors and vice versa. Recommends checking for both if one wants to find
out if something is an error.

PR-URL: #46840
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

RafaelGSS pushed a commit that referenced this pull request

Apr 7, 2023 
Makes clear what a native error is by linking the spec. Explains that
`instanceof Error` and util.types.isNativeError() are not equivalent.
Give examples for objects that are `instance of Error` but not native
errors and vice versa. Recommends checking for both if one wants to find
out if something is an error.

PR-URL: #46840
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

danielleadams pushed a commit that referenced this pull request

Jul 6, 2023 
Makes clear what a native error is by linking the spec. Explains that
`instanceof Error` and util.types.isNativeError() are not equivalent.
Give examples for objects that are `instance of Error` but not native
errors and vice versa. Recommends checking for both if one wants to find
out if something is an error.

PR-URL: #46840
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>