doc: update incorrect links by noel046 · Pull Request #47085 · nodejs/node
Review requested:
- @nodejs/net
labels
This was referenced
update incorrect links #47070
doc: update incorrect links
@noel046 For now, PR title is only changed. But we need to change commit title(not PR of github) in git.
@noel046 For now, PR title is only changed. But we need to change commit title(not PR of github) in git.
The merge commit will need to be removed too. I'll do that now and force push.
The CI failure is relevant. This breaks links in the single-page version of the doc.
| [`'drain'`]: #event-drain | ||
| [`'end'`]: #event-end | ||
| [`'error'`]: #event-error_1 | ||
| [`'error'`]: #event-error-1 |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current anchor exists in our HTML docs. The new one does not. What is the motivation for this change? Is it to fix something in the GitHub markdown rendering of this doc?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was referenced
Please also add a
Fixes: https://github.com/nodejs/node/issues/47070
to the commit message.
Can we get this merged soon? We've been getting more and more identical PRs for the same (or a subset of) changes.
@mscdex did the issues Trott and me mentioned get resolved?
@ovflowd I don't know. However from my recollection we tend to give the first to submit a PR for a specific set of changes priority, but as this PR has been open for over a month with others willing to make the same changes, we need to decide whether to continue waiting or close this PR and give others a chance to make the changes needed.
