[v19.x backport] deps: V8: cherry-pick cb30b8e17429 by RaisinTen · Pull Request #47307 · nodejs/node
added
build
labels
RaisinTen
added
the
author ready
label
RaisinTen
changed the base branch from
main
to
v19.x-staging
RaisinTen
changed the title
deps: V8: cherry-pick cb30b8e17429
[v19.x] deps: V8: cherry-pick cb30b8e17429
Original commit message:
Fix compilation error in platform.h for ASAN
The last two operands of the conditional expression needs to be
of the same type to compile.
Change-Id: Ib6cba4acb1238394910c650c776a7fd1ee93721e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4306802
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#86235}
Refs: v8/v8@cb30b8e
Refs: nodejs#43370
Signed-off-by: Darshan Sen <raisinten@gmail.com>
RaisinTen
changed the title
[v19.x] deps: V8: cherry-pick cb30b8e17429
[v19.x backport] deps: V8: cherry-pick cb30b8e17429
RaisinTen
removed
the
author ready
label
RaisinTen
added
the
author ready
label
RaisinTen added a commit that referenced this pull request
Original commit message:
Fix compilation error in platform.h for ASAN
The last two operands of the conditional expression needs to be
of the same type to compile.
Change-Id: Ib6cba4acb1238394910c650c776a7fd1ee93721e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4306802
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#86235}
Refs: v8/v8@cb30b8e
Refs: #43370
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #47307
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RaisinTen
deleted the
fix-compilation-error-in-platform.h-for-ASAN
branch
RafaelGSS pushed a commit that referenced this pull request
Original commit message:
Fix compilation error in platform.h for ASAN
The last two operands of the conditional expression needs to be
of the same type to compile.
Change-Id: Ib6cba4acb1238394910c650c776a7fd1ee93721e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4306802
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#86235}
Refs: v8/v8@cb30b8e
Refs: #43370
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #47307
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>