esm: bypass CommonJS loader under `--default-type=module` by GeoffreyBooth · Pull Request #49986 · nodejs/node
labels
…extension searching; fix lint
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request
PR-URL: nodejs#49986 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit to targos/node that referenced this pull request
PR-URL: nodejs#49986 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit to targos/node that referenced this pull request
PR-URL: nodejs#49986 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request
PR-URL: #49986 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit to targos/node that referenced this pull request
PR-URL: nodejs#49986 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request
ckerr added a commit to electron/electron that referenced this pull request
no code changes; patch just needed an update due to nearby upstream changes Xref: nodejs/node#49986
ckerr added a commit to electron/electron that referenced this pull request
…patch Xref: nodejs/node#49986 minor manual changes needed to sync with upstream change
codebytere pushed a commit to electron/electron that referenced this pull request
no code changes; patch just needed an update due to nearby upstream changes Xref: nodejs/node#49986
codebytere pushed a commit to electron/electron that referenced this pull request
…patch Xref: nodejs/node#49986 minor manual changes needed to sync with upstream change
codebytere added a commit to electron/electron that referenced this pull request
* chore: bump node in DEPS to v20.10.0 * chore: update feat_initialize_asar_support.patch no code changes; patch just needed an update due to nearby upstream changes Xref: nodejs/node#49986 * chore: update pass_all_globals_through_require.patch no manual changes; patch applied with fuzz Xref: nodejs/node#49657 * chore: update refactor_allow_embedder_overriding_of_internal_fs_calls Xref: nodejs/node#49912 no code changes; patch just needed an update due to nearby upstream changes * chore: update chore_allow_the_node_entrypoint_to_be_a_builtin_module.patch Xref: nodejs/node#49986 minor manual changes needed to sync with upstream change * update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch Xref: nodejs/node#50096 Xref: nodejs/node#50314 in lib/internal/modules/esm/load.js, update the code that checks for `format === 'electron'`. I'd like 👀 on this Xref: nodejs/node#49657 add braces in lib/internal/modules/esm/translators.js to sync with upstream * fix: lazyload fs in esm loaders to apply asar patches * nodejs/node#50127 * nodejs/node#50096 * esm: jsdoc for modules code nodejs/node#49523 * test: set test-cli-node-options as flaky nodejs/node#50296 * deps: update c-ares to 1.20.1 nodejs/node#50082 * esm: bypass CommonJS loader under --default-type=module nodejs/node#49986 * deps: update uvwasi to 0.0.19 nodejs/node#49908 * lib,test: do not hardcode Buffer.kMaxLength nodejs/node#49876 * crypto: account for disabled SharedArrayBuffer nodejs/node#50034 * test: fix edge snapshot stack traces nodejs/node#49659 * src: generate snapshot with --predictable nodejs/node#48749 * chore: fixup patch indices * fs: throw errors from sync branches instead of separate implementations nodejs/node#49913 * crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey nodejs/node#50234 * esm: detect ESM syntax in ambiguous JavaScrip nodejs/node#50096 * fixup! test: fix edge snapshot stack traces * esm: unflag extensionless ES module JavaScript and Wasm in module scope nodejs/node#49974 * [tagged-ptr] Arrowify objects https://chromium-review.googlesource.com/c/v8/v8/+/4705331 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
debadree25 pushed a commit to debadree25/node that referenced this pull request
PR-URL: nodejs#49986 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
bilbospocketses added a commit to bilbospocketses/ws-scrcpy-web that referenced this pull request
…p ErrorEvent Node 24 (repo engines floor) has Event, CloseEvent, and MessageEvent as globals — the typeof checks in Event.ts / CloseEventClass.ts / MessageEventClass.ts always picked native on any supported runtime. Inlining native constructors at the 5 Multiplexer/Message call sites and deleting the three dead polyfill files. ErrorEvent is NOT yet a Node global — verified on Node 24.14.1 via 'typeof ErrorEvent === "undefined"' (tracked upstream at nodejs/node#49986; internal-only ErrorEvent lives in undici). Kept ErrorEventClass.ts and rewrote it to extend native Event (it previously extended the now-deleted Event2). Runtime smoke test confirms the polyfill dispatches and listeners see error/message/filename/lineno/colno fields correctly. Net: -137/+18 across 6 files, 0 tsc errors, 89/89 tests pass, webpack clean, generated .d.ts byte-identical (920 bytes).
bilbospocketses added a commit to bilbospocketses/ws-scrcpy-web that referenced this pull request
…p ErrorEvent Node 24 (repo engines floor) has Event, CloseEvent, and MessageEvent as globals — the typeof checks in Event.ts / CloseEventClass.ts / MessageEventClass.ts always picked native on any supported runtime. Inlining native constructors at the 5 Multiplexer/Message call sites and deleting the three dead polyfill files. ErrorEvent is NOT yet a Node global — verified on Node 24.14.1 via 'typeof ErrorEvent === "undefined"' (tracked upstream at nodejs/node#49986; internal-only ErrorEvent lives in undici). Kept ErrorEventClass.ts and rewrote it to extend native Event (it previously extended the now-deleted Event2). Runtime smoke test confirms the polyfill dispatches and listeners see error/message/filename/lineno/colno fields correctly. Net: -137/+18 across 6 files, 0 tsc errors, 89/89 tests pass, webpack clean, generated .d.ts byte-identical (920 bytes).