◐ Shell
clean mode source ↗

src: add commit hash shorthand in zlib version by MrJithil · Pull Request #50158 · nodejs/node

src: add commit hash shorthand in zlib version

@nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci

PRs that need a full CI run.

tools

Issues and PRs related to the tools directory.

labels

Oct 12, 2023

marco-ippolito

marco-ippolito

@marco-ippolito marco-ippolito added author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

and removed needs-ci

PRs that need a full CI run.

labels

Oct 15, 2023

@MrJithil MrJithil deleted the fix-50139-add-commit-shorthand-in-zlib branch

October 23, 2023 20:57

alexfernandez pushed a commit to alexfernandez/node that referenced this pull request

Nov 1, 2023
src: add commit hash shorthand in zlib version
PR-URL: nodejs#50158
Fixes: nodejs#50139
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

targos pushed a commit that referenced this pull request

Nov 11, 2023
src: add commit hash shorthand in zlib version
PR-URL: #50158
Fixes: #50139
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

This was referenced

Nov 28, 2023

nodejs-github-bot pushed a commit that referenced this pull request

Dec 4, 2023
Report the version of the dynamically linked zlib if built with
`configure --shared-zlib` instead of the hardcoded version that
corresponds to the bundled version of zlib in `deps`.

PR-URL: #51007
Refs: #50910
Refs: #50158
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

UlisesGascon pushed a commit that referenced this pull request

Dec 11, 2023
src: add commit hash shorthand in zlib version
PR-URL: #50158
Fixes: #50139
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

RafaelGSS pushed a commit that referenced this pull request

Dec 15, 2023
Report the version of the dynamically linked zlib if built with
`configure --shared-zlib` instead of the hardcoded version that
corresponds to the bundled version of zlib in `deps`.

PR-URL: #51007
Refs: #50910
Refs: #50158
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

codebytere added a commit to electron/electron that referenced this pull request

Jan 10, 2024

zcbenz pushed a commit to electron/electron that referenced this pull request

Jan 12, 2024

zcbenz pushed a commit to electron/electron that referenced this pull request

Jan 12, 2024

codebytere added a commit to electron/electron that referenced this pull request

Jan 15, 2024

codebytere added a commit to electron/electron that referenced this pull request

Jan 15, 2024

codebytere added a commit to electron/electron that referenced this pull request

Jan 16, 2024

codebytere added a commit to electron/electron that referenced this pull request

Jan 18, 2024

jkleinsc pushed a commit to electron/electron that referenced this pull request

Jan 18, 2024

codebytere added a commit to electron/electron that referenced this pull request

Jan 18, 2024

jkleinsc pushed a commit to electron/electron that referenced this pull request

Jan 18, 2024
* chore: bump node in DEPS to v20.11.0

* module: bootstrap module loaders in shadow realm

nodejs/node#48655

* src: add commit hash shorthand in zlib version

nodejs/node#50158

* v8,tools: expose necessary V8 defines

nodejs/node#50820

* esm: do not call getSource when format is commonjs

nodejs/node#50465

* esm: fallback to readFileSync when source is nullish

nodejs/node#50825

* vm: allow dynamic import with a referrer realm

nodejs/node#50360

* test: skip test-diagnostics-channel-memory-leak.js

nodejs/node#50327

* esm: do not call getSource when format is commonjs

nodejs/node#50465

* lib: fix assert throwing different error messages in ESM and CJS

nodejs/node#50634

* src: fix compatility with upcoming V8 12.1 APIs

nodejs/node#50709

* deps: update base64 to 0.5.1

nodejs/node#50629

* src: avoid silent coercion to signed/unsigned int

nodejs/node#50663

* src: fix compatility with upcoming V8 12.1 APIs

nodejs/node#50709

* chore: fix patch indices

* chore: update patches

* test: disable TLS cipher test

This can't be enabled owing to BoringSSL incompatibilities.

nodejs/node#50186

* fix: check for Buffer and global definition in shadow realm

nodejs/node#51239

* test: disable parallel/test-shadow-realm-custom-loader

Incompatible with our asar logic, resulting in the following failure:

> Failed to CompileAndCall electron script: electron/js2c/asar_bundle

* chore: remove deleted parallel/test-crypto-modp1-error test

* test: make test-node-output-v8-warning generic

nodejs/node#50421

* chore: fixup ModuleWrap patch

* test: match wpt/streams/transferable/transform-stream-members.any.js to upstream

* fix: sandbox is not enabled on arm

* chore: disable v8 sandbox on ia32/arm

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>

richardlau added a commit that referenced this pull request

Mar 25, 2024
Report the version of the dynamically linked zlib if built with
`configure --shared-zlib` instead of the hardcoded version that
corresponds to the bundled version of zlib in `deps`.

PR-URL: #51007
Refs: #50910
Refs: #50158
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>